Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-882: Add unit tests for burn_all() and burn() extrinsics #1433

Merged
merged 2 commits into from
Dec 18, 2023
Merged

CSUB-882: Add unit tests for burn_all() and burn() extrinsics #1433

merged 2 commits into from
Dec 18, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4141072) 70.64% compared to head (dbb46e0) 72.20%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1433      +/-   ##
==========================================
+ Coverage   70.64%   72.20%   +1.56%     
==========================================
  Files         111      111              
  Lines       13009    13123     +114     
  Branches      128      128              
==========================================
+ Hits         9190     9476     +286     
+ Misses       3819     3637     -182     
- Partials        0       10      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atodorov atodorov force-pushed the testing/CSUB-882-add-unit-tests branch from 8f3cb10 to cfc0d97 Compare December 15, 2023 13:48
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the testing/CSUB-882-add-unit-tests branch from 51be2be to ffdd53a Compare December 15, 2023 20:10
@atodorov atodorov force-pushed the testing/CSUB-882-add-unit-tests branch from ffdd53a to dbb46e0 Compare December 15, 2023 20:11
@atodorov atodorov marked this pull request as ready for review December 15, 2023 20:11
@atodorov atodorov merged commit ea2799b into dev Dec 18, 2023
36 of 38 checks passed
@atodorov atodorov deleted the testing/CSUB-882-add-unit-tests branch December 18, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@pLabarta pLabarta Awaiting requested review from pLabarta

@frankli-dev frankli-dev Awaiting requested review from frankli-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atodorov @codecov-commenter